search

dlanger / inlinestyler

A simple CSS inliner for generating HTML email messages.
http://pypi.python.org/pypi/inlinestyler
BSD 3-Clause "New" or "Revised" License
114 stars 23 forks source link

GZIP support #13

Closed Arvi3d closed 9 years ago

Arvi3d commented 9 years ago

Recognize GZIPed style files and decompress it

Arvi3d commented 9 years ago

Please merge this pull request asap. Your app is awesome. I'd like to use official release from PYPI, not github repo

dlanger commented 9 years ago

Interesting idea, I'll take a look this evening when I get home.

Arvi3d commented 9 years ago

Ok, let me know, if there are some issues. It works for me pretty well. I already put it to production.

On 09 Jun 2015, at 19:44, Daniel Langer notifications@github.com wrote:

Interesting idea, I'll take a look this evening when I get home.

— Reply to this email directly or view it on GitHub https://github.com/dlanger/inlinestyler/pull/13#issuecomment-110443872.

dlanger commented 9 years ago

@Arvi3d I'm not going to merge this one, as I (think I) solved the same problem by replacing urllib with with requests, which I'd been meaning to do for a while (and which does gzip out of the box) - see aafbb4f2c468003e1910aeadc233fa596df70e37

I've pushed a new version to PyPI - if that doesn't work for you, we can re-evaluate why and I'll push another one.

Arvi3d commented 9 years ago

Thank you very much for your effort. I’ll check it.

On 10 Jun 2015, at 04:20, Daniel Langer notifications@github.com wrote:

@Arvi3d https://github.com/Arvi3d I'm not going to merge this one, as I (think I) solved the same problem by replacing urllib with with requests, which I'd been meaning to do for a while (and which does gzip out of the box http://docs.python-requests.org/en/latest/community/faq/#encoded-data).

I've pushed a new version to PyPI - if that doesn't work for you, we can re-evaluate why and I'll push another one.

— Reply to this email directly or view it on GitHub https://github.com/dlanger/inlinestyler/pull/13#issuecomment-110560496.

Arvi3d commented 9 years ago

yes, it works. thanks.

On 10 Jun 2015, at 09:47, Private arvi3d arvi3d@gmail.com wrote:

Thank you very much for your effort. I’ll check it.

On 10 Jun 2015, at 04:20, Daniel Langer <notifications@github.com mailto:notifications@github.com> wrote:

@Arvi3d https://github.com/Arvi3d I'm not going to merge this one, as I (think I) solved the same problem by replacing urllib with with requests, which I'd been meaning to do for a while (and which does gzip out of the box http://docs.python-requests.org/en/latest/community/faq/#encoded-data).

I've pushed a new version to PyPI - if that doesn't work for you, we can re-evaluate why and I'll push another one.

— Reply to this email directly or view it on GitHub https://github.com/dlanger/inlinestyler/pull/13#issuecomment-110560496.