search

dlanger / inlinestyler

A simple CSS inliner for generating HTML email messages.
http://pypi.python.org/pypi/inlinestyler
BSD 3-Clause "New" or "Revised" License
114 stars 23 forks source link

lxml v5 breaks the lib #32

Open femesq opened 8 months ago

femesq commented 8 months ago

When updating lxml > 5 I've got AttributeError exception:

 'CSSSelector' object has no attribute 'evaluate'
 matching = CSSRelSelector.evaluate(document)

in this line: https://github.com/dlanger/inlinestyler/blob/master/inlinestyler/converter.py#L30

femesq commented 8 months ago

Reopening until merged...

selva-thiruarul commented 5 months ago

facing the same issue, any update on this ?

femesq commented 5 months ago

@selva-thiruarul Check this: https://github.com/femesq/inlinestyler/commit/488c5989e4f78716614edcbb80afd9dc9759a67d

Don't know if the official lib is being maintained, so I can't say this fix will be merged.

selva-thiruarul commented 5 months ago

Thanks @femesq. I switched to css-inline. It works

dlanger commented 5 months ago

That's probably the right call - as the README says, this is pretty much unmaintained.

rcarmo commented 5 months ago

Came here to report this, sad to see it unmaintained.