Install certificates when restart() is called

dlapiduz / certbot-s3front

Certbot CLI plugin for S3/CloudFront validation and installation

MIT License

584 stars 70 forks source link

Install certificates when restart() is called #60

Closed crgwbr closed 5 years ago

crgwbr commented 6 years ago

Currently, this plugin will never install certificates obtained during a renewal. This is due to certbot only calling deploy_cert() for the initial certificate (https://github.com/certbot/certbot/issues/4046). This PR works around this limitation by using the restart() method to upload updated certificates to AWS.

jwarren116 commented 6 years ago

Is this a priority? I've been running into the same issue on renewals.

dlapiduz commented 6 years ago

Hi @crgwbr , thanks for the PR and apologies for the delay.

I've been reading about the renew APIs and decided to go with the more native way of doing renewals. Can you please check if https://github.com/dlapiduz/certbot-s3front/commit/5991508574c1ba8fd8862b106e9671a5327da5cb fixes the issue?

Thanks!