dlapiduz / certbot-s3front

Certbot CLI plugin for S3/CloudFront validation and installation
MIT License
584 stars 70 forks source link

Install certificates in CloudFront on renew #66

Closed jwarren116 closed 5 years ago

jwarren116 commented 6 years ago

Like is mentioned in https://github.com/dlapiduz/certbot-s3front/pull/60, certbot does not call deploy_cert() on a renew. After running the branch in the above PR I ran into a few issues. This PR serves to fix those issues and builds on top of the branch https://github.com/crgwbr submitted in https://github.com/dlapiduz/certbot-s3front/pull/60.

dlapiduz commented 6 years ago

Hi @jwarren116, thanks for the PR and apologies for the delay.

I've been reading about the renew APIs and decided to go with the more native way of doing renewals. Can you please check if https://github.com/dlapiduz/certbot-s3front/commit/5991508574c1ba8fd8862b106e9671a5327da5cb fixes the issue?

Thanks!