Closed jwarren116 closed 5 years ago
Hi @jwarren116, thanks for the PR and apologies for the delay.
I've been reading about the renew APIs and decided to go with the more native way of doing renewals. Can you please check if https://github.com/dlapiduz/certbot-s3front/commit/5991508574c1ba8fd8862b106e9671a5327da5cb fixes the issue?
Thanks!
Like is mentioned in https://github.com/dlapiduz/certbot-s3front/pull/60, certbot does not call
deploy_cert()
on a renew. After running the branch in the above PR I ran into a few issues. This PR serves to fix those issues and builds on top of the branch https://github.com/crgwbr submitted in https://github.com/dlapiduz/certbot-s3front/pull/60.le-my.domain.com-0123456789
, so the local path therestart()
was using was incorrect (it was assumed that certificate name was the same as the domain).deploy_cert()
for all certificates, not just the one I was renewing. This actually resulted in some certificates being deployed and deleted that I didn't want changed.example.com
would think the existing uploaded certificatefoo.example.com
was an old duplicate, and it would try to delete it.