search

dlareau / puzzlehunt_server

Server for Puzzle hunts run by Puzzlehunt CMU, but can be repurposed for other hunts.
MIT License
19 stars 16 forks source link

Support downloading pdfs from Google Drive rather than Dropbox #144

Closed samuel-yeom closed 4 years ago

samuel-yeom commented 4 years ago

The staff now uses a Google shared drive to store puzzles, so it would be nice if the server can download files from a public Google Drive link.

Currently, the server tries and fails to load the Google Drive preview of the pdf.

dlareau commented 4 years ago

How far would just adding a file upload button get towards satisfying your current workflow?

Google is being google and apparently a share link doesn't support any sort of normal file getting. The options knowing that are as follows: 1) You go through the process of creating the download link for each file before you put it in, which involves copying out the file ID from the URL and into a template link. (This sounds like it sucks a lot but requires no modifications) 2) I modify the backend to use some google drive command line fetch tool, this seems particularly brittle, and would need the user to specify on the front end for each puzzle if the source of the puzzle is google drive (I could of course make it true by default). I don't love this solution as it breaks the sort of abstraction layer of not having to care where the PDF is from (the current solution doesn't bake in dropbox in any way, it just calls wget and dropbox actually gives the file upon attempting to download a share link like a reasonable file hosting server, unlike google). However this solution is essentially the only way to get the behavior you asked for which is what matters in the end. 3) Go through with adding a file upload button already like I've been posturing to do in #121 . This makes it very universal and possibly easier for iterative development, but if your files are already all in the cloud it adds another step of downloading them rather than removing a step of uploading them.

Lemme know what you think.

samuel-yeom commented 4 years ago

I think the third solution is the best, especially since it's the most intuitive for new staff members.

dlareau commented 4 years ago

Now in v4.1.0, to be deployed very soon.