Closed SR-Coder closed 3 months ago
Just ran into this as well.
@dlarrick I don't have a laptop right now to create a PR but we just need to change the location we import save_json from. It is now in homeassistant.helpers.json
@SR-Coder if you are comfortable manually editing the file, you just need to change the lines in init.py and config_flow.py
Remove save_json from where it currently is (and the comma right before, then add a new line:
from homeassistant.helpers.json import save_json
@omriasta not a problem I will make those changes and report back! Thanks for the quick response!
@dlarrick I was able to create a PR on my phone because it was just 2 lines of code. I am not sure if this will break previous versions of HA though.
@SR-Coder you can see what needs to be updated here: https://github.com/dlarrick/hass-kumo/pull/162/files
@omriasta Thanks for the super quick response, HA is running a database update so when that is done I will restart and that should reload Kumo Integration. Perhaps until a final solution is made wrap the import in a try and except to handle the previous versions importing from a different location. cheers
Yep, that may be the way to go...just hard to write up from my phone.
I will just make the next version depend on whenever they put that function in its new location. -Doug
On Wed, Aug 7, 2024, 5:52 PM omriasta @.***> wrote:
Yep, that may be the way to go...just hard to write up from my phone.
— Reply to this email directly, view it on GitHub https://github.com/dlarrick/hass-kumo/issues/161#issuecomment-2274412140, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUE6FOJAWUVGJOQRMASX23ZQKJJXAVCNFSM6AAAAABMFGZKWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZUGQYTEMJUGA . You are receiving this because you were mentioned.Message ID: @.***>
Breadcrumb: https://github.com/home-assistant/core/pull/88099 introduced save_json
to helpers
I made the edit to files as @SR-Coder directed. Kumo is working. Thanks
Fixed in v0.3.14 . I bumped the HACS dependency on HomeAssistant version to be one with the required save_json function. The manifest dependency was already fine.
Kumo integration fails to load.