search

dlarrick / hass-kumo

Home Assistant module interfacing with Mitsubishi mini-split units
MIT License
99 stars 23 forks source link

Add ClimateEntityFeature.TURN_OFF for Google Assistant calls #163

Open bryanyork opened 3 months ago

bryanyork commented 3 months ago

Google Assistant expects to call the turn_off service which does not exist unless specifically enabled as a ClimateEntityFeature.TURN_OFF feature.

Previously calls to turn off my Kumo devices would fail silently from Google and an error message in Home Assistant regarding an unsupported service.

I have tested this change to fix my issue.

bryanyork commented 3 months ago

Discussion in #137

bryanyork commented 3 months ago

@dlarrick any thoughts on this one? Seems to work great for my setup. (Both via Google Assistant and Home Assistant apps)

dlarrick commented 3 months ago

Didn't we remove this to stop some deprecation warning? Let me dig up that PR too...

dlarrick commented 3 months ago

Yeah -- https://github.com/dlarrick/hass-kumo/pull/155 which references https://github.com/dlarrick/hass-kumo/issues/137

So with this change to your local files you're not seeing that warning? Or if you are, can you research the proper way to fix all this?