dlarrick / hass-kumo

Home Assistant module interfacing with Mitsubishi mini-split units
MIT License
97 stars 21 forks source link

Fix set_temperature for heat_cool mode #28

Closed FrancisLab closed 4 years ago

FrancisLab commented 4 years ago

Address issues highlighted in https://github.com/dlarrick/hass-kumo/issues/27

Was able to test on previous versions of hass-kumo, but currently blocked from testing on v0.1.4 due to other issues.

FrancisLab commented 4 years ago

We've figured out the issues blocking me from testing on v.0.1.4. So here we go:

Test Plan

Setting Auto-mode temperature

  1. Set unit in auto mode
  2. Use climate.set_temperature service call to set new target_temp_low & target_temp_high
  3. Ensure UI updates to reflect new temperatures within one minute
  4. Ensure no error logs in HASS
  5. Ensure proper status in Kumo Cloud app

Setting Head mode temperature

  1. Set unit in heat mode
  2. Use climate.set_temperature service call to set new temperature
  3. Ensure UI updates to reflect new temperature within one minute
  4. Ensure no error logs in HASS
  5. Ensure proper status in Kumo Cloud app

Setting Cool mode temperature

  1. Same as above with cool mode

Not setting temperature in other modes

  1. Set unit in vent mode
  2. Use climate.set_temperature service call to try setting new temperature
  3. Ensure no UI updates for a minute
  4. Ensure "not setting target temperature for mode" is logged in HASS
  5. Ensure proper status in Kumo Cloud app
dlarrick commented 4 years ago

I did push 0.1.5 which might make your testing easier / more consistent.

FrancisLab commented 4 years ago

I ended up testing everything on 0.1.4. I can do it again on 0.1.5 if you'd like.

dlarrick commented 4 years ago

I ended up testing everything on 0.1.4. I can do it again on 0.1.5 if you'd like.

No that's fine. So we're all good?

FrancisLab commented 4 years ago

I went ahead and also tested on 0.1.5! Everything works fine as far as I can tell!

Thanks for fixing the latency issue, it's super responsive now!

dlarrick commented 4 years ago

All right, merged and new release pushed. I am going to close the issue now.