search

dlarrick / hass-kumo

Home Assistant module interfacing with Mitsubishi mini-split units
MIT License
96 stars 21 forks source link

was in the wrong directory sorry #62

Closed omriasta closed 2 years ago

omriasta commented 2 years ago

@dlarrick I was in the wrong directory and did something wrong, it's no showing that something has been pushed, can you reverse this? I need to get my fork up to date and then I will submit a normal PR from my fork...

dlarrick commented 2 years ago

There have been no commits to this repo on any branch since September. Perhaps you pushed to your own fork?

dlarrick commented 2 years ago

Oh maybe you re-pushed the ip-assign-feature branch? That one was deleted after merge but it's back.

omriasta commented 2 years ago

probably...I have no idea what I am doing in github. I need to submit a PR to change "confirm" in line 158 of config_flow.py to "request_ips" but I can't get my fork to reset to be at the same place as you are...

omriasta commented 2 years ago

You should remove my access so I don't mess anything up. Let me figure out my fork and I will submit as soon as I figure it out

dlarrick commented 2 years ago

Since you have permissions on this repo you're probably better off starting fresh and just push a new branch to here. Go to a new directory and:

git clone https://github.com/dlarrick/hass-kumo.git
cd hass-kumo
git checkout -b fix_confirm_branch
<make your change>
<git add and git commit as usual>
git push --set-upstream origin fix_confirm_branch

Then come back here and make a pull request to master.

omriasta commented 2 years ago

I think I got it....one of these days I'll understand github :)