dlarrick / hass-kumo

Home Assistant module interfacing with Mitsubishi mini-split units
MIT License
96 stars 21 forks source link

KumoThermostat implements device_state_attributes #71

Closed danielgoepp closed 2 years ago

danielgoepp commented 2 years ago

I'm not sure what the problem is here yet, but am going to take a look to see if I can learn more. I just upgraded to Home Assistant 2021.12.0 and now I'm getting this message. It seems for now it's a warning, and doesn't break anything.

home-assistant    | 2021-12-11T22:13:08.145235225Z 2021-12-11 17:13:08 WARNING (MainThread) [homeassistant.helpers.entity] Entity climate.studio_a_kumo (<class 'custom_components.kumo.climate.KumoThermostat'>) implements device_state_attributes. Please report it to the custom component author.
home-assistant    | 2021-12-11T22:13:08.147448514Z 2021-12-11 17:13:08 WARNING (MainThread) [homeassistant.helpers.entity] Entity climate.greatroom_kumo (<class 'custom_components.kumo.climate.KumoThermostat'>) implements device_state_attributes. Please report it to the custom component author.
home-assistant    | 2021-12-11T22:13:08.149200053Z 2021-12-11 17:13:08 WARNING (MainThread) [homeassistant.helpers.entity] Entity climate.guestroom_kumo (<class 'custom_components.kumo.climate.KumoThermostat'>) implements device_state_attributes. Please report it to the custom component author.
home-assistant    | 2021-12-11T22:13:08.151810262Z 2021-12-11 17:13:08 WARNING (MainThread) [homeassistant.helpers.entity] Entity climate.bedroom_kumo (<class 'custom_components.kumo.climate.KumoThermostat'>) implements device_state_attributes. Please report it to the custom component author.
omriasta commented 2 years ago

Should be a simple fix but I'm bad with GitHub.... Line 509 from climate.py should be changed from device_state_attributes to extra_state_attributes this worked for me but if you could test and then maybe setup a PR?

danielgoepp commented 2 years ago

Sure, thanks @omriasta. I'll update that, test and submit.

danielgoepp commented 2 years ago

Done. Thanks for clarifying @omriasta. I verified this resolves the issue.

https://github.com/dlarrick/hass-kumo/pull/72

dlarrick commented 2 years ago

Merged.