search

dlarrick / pykumo

Python library to interact with Mitsubishi KumoCloud devices via their local API
MIT License
35 stars 12 forks source link

Expose Sensor Temperature #12

Open fabi125 opened 3 years ago

fabi125 commented 3 years ago

Hi there!

Right now the library only exposes the roomTemp, but sensors have a temperature as well. In my case the roomTemp can only display 0.5 degree accuracy, whereas the sensor - at least seems - much preciser.

Mainly opening this FR to discuss what way you think this should be exposed (I'm happy to send a PR afterwards).

My simple idea would be to have get_current_temperature() return the sensor's temperature if available and then fall back to roomTemp. How does that sound?

Thanks! Fabi

dlarrick commented 1 year ago

Sorry for the long-delayed response. Yes, since the sensor's temperature seems to be reported with greater precision I'd accept a small PR to return the sensor's temperature, if present, and fall back to the current method otherwise.