search

dlazaro66 / QRCodeReaderView

Modification of ZXING Barcode Scanner project for easy Android QR-Code detection and AR purposes
1.9k stars 491 forks source link

add front camera functionality, opening camera by id #39

Closed ashishgaurav13 closed 8 years ago

ashishgaurav13 commented 8 years ago

I modified some more zxing to add the feature for opening camera by id. For < SDK 9, it defaults to id 0. Using this, someone can pass in the id for front camera, or any other camera. I tested it on another application I'm working on for a front camera.

dlazaro66 commented 8 years ago

Hi @agaurav77 ! I really appreciate your work, I'm trying to taking up this project again, and this pull requests really help. So, I'm checking your PR and I'll merge it asap, thanks!

ashishgaurav13 commented 8 years ago

@dlazaro66 Thanks, please do merge if you think its okay. @VAdaihiep You are correct in your way! I did it the same way.

Anyways, I didn't add a specific function for doing exactly this, i.e. switching from front-to-back and vice versa, because, its almost obvious how to do it if the more critical functionality was implemented, which is, to change the camera ID that the QR code reader view operates on. Then, anyone can use any ID, not just the front camera. It is just the matter of writing code to find the ID of the front camera (googling will give you a way) then. But nice to know it worked!

Apologies for the delay, had some work.

dlazaro66 commented 8 years ago

Hello! We're doing improvements in this library, so this pull request just got out of date. Anyway, I added a function to specify which camera you want to open, so the functionality is the same as your PR did. It's done now but not released yet, I hope it can be released soon.

Thanks for the contribution and the effort of doing this pull request.