search

dlbeer / mspdebug

Debugging tool for MSP430 MCUs
GNU General Public License v2.0
184 stars 80 forks source link

Makefile doesn't set needed -framework PORTS_LDFLAGS for Fink #104

Open nieder opened 3 years ago

nieder commented 3 years ago

Makefile only sets -framework IOKit -framework CoreFoundation for MacPorts and homebrew. When building mspdebug with Fink, those flags aren't added and the build fails with the relevant missing symbols. Adding them at line 76 makes the build finish.

https://github.com/dlbeer/mspdebug/blob/66dd71e62dea2fd3b7db9558abeab2e1d54793fc/Makefile#L74-L85

Is there some issue that needs the various packagers to have their own commands? The MacPorts and Homebrew chunks are already the same. Using pkg-config should be enough already to pick up any differences between the various systems w/out needing mspdebug to keep track of them.

Also, are -ltermcap -pthread needed specifically for Fink? The build finishes fine if I comment those two flags out and I don't see any use of ncurses in the code.

dlbeer commented 3 years ago

On Mon, Apr 05, 2021 at 05:52:08AM -0700, nieder wrote:

Makefile only sets -framework IOKit -framework CoreFoundation for MacPorts and homebrew. When building mspdebug with Fink, those flags aren't added and the build fails with the relevant missing symbols. Adding them at line 76 makes the build finish.

https://github.com/dlbeer/mspdebug/blob/66dd71e62dea2fd3b7db9558abeab2e1d54793fc/Makefile#L74-L85

Is there some issue that needs the various packagers to have their own commands? The MacPorts and Homebrew chunks are already the same. Using pkg-config should be enough already to pick up any differences between the various systems w/out needing mspdebug to keep track of them.

Unfortunately I don't have access to a Mac to test any of this, but I'd be happy to accept a patch or pull request to fix things up.

Also, are -ltermcap -pthread needed specifically for Fink? The build finishes fine if I comment those two flags out and I don't see any use of ncurses in the code.

Not sure about Fink, but readline is an optional dependency, and -pthread is required on OpenBSD if I remember correctly.

Cheers, Daniel

-- Daniel Beer @.***> http://dlbeer.co.nz/ PGP: BA6E 0B26 1F89 246C E3F3 C910 1E58 C43A 160A 553B