search

dlbeer / quirc

QR decoder library
Other
865 stars 285 forks source link

Add OpenCV version of inspect #105

Closed yamt closed 2 years ago

kaworu commented 3 years ago

Hello @yamt and thanks for the PR. Visually I find the result quite different from inspect, is that expected? 2021-05-02-220715_1920x1080_scrot 2021-05-02-220729_1920x1080_scrot

yamt commented 3 years ago

Hello @yamt and thanks for the PR. Visually I find the result quite different from inspect, is that expected? 2021-05-02-220715_1920x1080_scrot 2021-05-02-220729_1920x1080_scrot

i haven't used sdl version at all.

when i was developing this, i was using quite large images. (like 12M pixels) it might explain the larger annotations.

if you provide some pairs of qr code images and sdl screenshots, i can try to mimic them closely.

yamt commented 3 years ago

the last push is just a conflict resolution

yamt commented 3 years ago

the last push fixed crashes in pixelColor().

yamt commented 2 years ago

@kaworu ping?

dlbeer commented 2 years ago

I agree that it would be nice for them to be consistent, but it looks ok for now -- thanks!

yamt commented 2 years ago

Sorry, was offline for a time. The image I used for the screenshot above was https://github.com/kaworu/node-quirc/raw/master/test/data/Hello%2BWorld.png. Diff LGTM, not fundamentally opposed to have opencv visually rendering differently from SDL but IMHO a little consistency would be nice to have.

thank you. i tweaked this to match the sdl version. https://github.com/dlbeer/quirc/pull/115