dlbeer / quirc

QR decoder library
Other
865 stars 285 forks source link

QR Code generated by freeotp website not detected: ECC error #112

Closed jhaygood86 closed 2 years ago

jhaygood86 commented 2 years ago

freeotp

The attached image can be identified as a QR code, but the data cannot be decoded from it. It works with other QR Code readers (for instance, rando apps on Android)

kaworu commented 2 years ago

Thanks @jhaygood86 I was able to reproduce and inspect reports Decoding FAILED: ECC failure

dlbeer commented 2 years ago

Looks like an grid identification issue introduced by either #72 or #109 -- the A/B/C designations of the capstones are backwards (it's mixed horizontal/vertical grouping), so it's reading from a transposed grid. @JaapHaitsma would you have time to take a look at this and see if there's anything you can tweak here?

dlbeer commented 2 years ago

Looks like the commit is bff065d88b8ab3981925e6123537384321b02cad. If anyone needs a quick-fix, they can roll back to commit ceb1241735e10d464d492883646d8491209028f4 in the meantime.

JaapHaitsma commented 2 years ago

@dlbeer I will have a look at it