xrotwang commented 3 years ago

closes #21

xrotwang commented 3 years ago

@SimonGreenhill another question: I noticed that the format is read from the lowercased line, resulting in ...format: {.. 'missing': 'n' ...}, when in ...matrix.values() it may be N. Is this intentional?

SimonGreenhill commented 3 years ago

that lowercasing for format looks like a bug..

codecov-io commented 3 years ago

Codecov Report

Merging #22 (6cda2d2) into master (22a7981) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         2588      2612   +24     
=========================================
+ Hits          2588      2612   +24

Impacted Files	Coverage Δ
src/nexus/handlers/data.py	`100.00% <100.00%> (ø)`
tests/test_handler_DataHandler.py	`100.00% <100.00%> (ø)`
tests/test_maddison.py	`100.00% <100.00%> (ø)`
tests/test_regressions.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22a7981...6cda2d2. Read the comment docs.

xrotwang commented 3 years ago

Just had a look at the NEXUS spec. There's a RespectCase format setting, signaling that matrix data is to be read case sensitive (while the default is case insensitive) - which does not apply to some DataTypes ... But I guess we don't want to go down this rabbit hole.

xrotwang commented 3 years ago

(It also doesn't help to typeset keywords of a file format in the spec in small caps - just adds to the confusion ...)

dlce-eva / python-nexus

add support for wrapped data blocks #22

Codecov Report