Closed SimonGreenhill closed 2 years ago
(not urgent - no release required yet)
Merging #38 (346fabd) into master (32a07ad) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 59 59
Lines 2925 2930 +5
=========================================
+ Hits 2925 2930 +5
Impacted Files | Coverage Δ | |
---|---|---|
src/nexus/handlers/tree.py | 100.00% <100.00%> (ø) |
|
tests/test_handler_TreeHandler.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 32a07ad...346fabd. Read the comment docs.
Hmm. tests failing on 3.6 due to clldutils looking for re.Pattern which I think was added in 3.7 (not sure why 3.7 is timing out though). Should we remove support for 3.6?
ImportError while loading conftest '/home/runner/work/python-nexus/python-nexus/tests/conftest.py'.
tests/conftest.py:5: in <module>
from nexus import NexusReader
/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/nexus/__init__.py:4: in <module>
from nexus.reader import NexusReader
/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/nexus/reader.py:13: in <module>
from nexus.handlers.tree import TreeHandler
/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/nexus/handlers/tree.py:5: in <module>
from clldutils.text import strip_brackets, split_text_with_context
/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/clldutils/text.py:130: in <module>
def replace_pattern(pattern: typing.Union[str, re.Pattern], repl, text: str, flags=0) -> str:
E AttributeError: module 're' has no attribute 'Pattern'
Yes, I think we can remove support for 3.6.
Alternatively, we'd have to pin clldutils - but I think that's the worse option.
If a tree has no translate block and
detranslate
was called then an exception would be raised about the mismatch between the number of translate matches.._been_translated
correctly.(A,(B,C));
missedC
. This PR removes the regex and relies on the newick library to get the leaf labels.