dlcs / protagonist

MIT License
7 stars 2 forks source link

PDF rendered with everypage showing "Unable to display this page" #892

Closed donaldgray closed 1 month ago

donaldgray commented 2 months ago

PDFs have been generated for some images and every page is rendering "Unable to display this page" error. This is added by Fireball when it is given a Page and an S3 URI for the thumbnail but that thumb cannot be found.

After investigation it was found that the images in question all required auth and had a maxUnauthorised value. FireballPdfCreator, specifically https://github.com/dlcs/protagonist/blob/main/src/protagonist/Orchestrator/Infrastructure/NamedQueries/PDF/FireballPdfCreator.cs#L121-L134, method shows that it requests every thumbnail size (open or auth) but when calling StorageKeyGenerator.GetThumbnailLocation it doesn't specify whether the requested thumbnail is open or not so it defaults to open only. In this particular example the chosen thumbnails were restricted so couldn't be found.