dlcs / protagonist

MIT License
7 stars 2 forks source link

Only run build + test for draft PRs #894

Open donaldgray opened 1 month ago

donaldgray commented 1 month ago

Unsure if this is the best way to approach it; intent is to reduce build churn for draft PRs.

donaldgray commented 1 month ago

@JackLewis-digirati / @griffri - what are the thoughts on this? Wondering if we should bother running tests on draft PRs?

JackLewis-digirati commented 1 month ago

I think running the tests would be useful, I could see a time when some tests weren't run and now fail, meaning the PR needs to go back to the drawing board for additional work - by comparison, if the tests ran on draft, it would more quickly point out that there's unexpected issues in the PR

griffri commented 1 month ago

I agree with Jack - I think it would be useful to continue allowing tests run on draft PRs. It's good for spotting any overlooked issues before opening up the PR.