search

dldl / sphinx-preview

Sphinx preview in Atom
MIT License
5 stars 4 forks source link

Fixes for docker configuration when running on macOS (darwin) Mojave #16

Closed hileef closed 5 years ago

hileef commented 5 years ago

Potentially (aka works on my macOS Mojave machine) fixes #14

python-reload's file watcher behaves erratically when run in a docker environment when the host is macOS (darwin) Mojave, I believe it may be a bug either in the docker engine itself or in the darwin kernel when handling //double/slash/posix-n-win32-compatible/paths, as well as differing configuration.

This patch is based on having run docker inspect on the container as launched form the sphinx-preview plugin and as launched from the command line.

I have not encountered the problems mentioned in #14 with these patches, however given the erratic nature of the error it is very difficult to test in an automated way.

hileef commented 5 years ago

@Coac , could you have a look at the changes I have put in place and tell me if it's okay now ? Thanks in advance !

Coac commented 5 years ago

Thanks!