dlebansais / PgBuilder-Disclosed

A tool to optimize gear for a character of the Project: Gorgon MMORPG
3 stars 0 forks source link

Bard Song of Discord not displaying correct damage #4

Open Enphuego opened 2 years ago

Enphuego commented 2 years ago

The damage type is direct trauma damage (not indirect!) It's weird, I know, but I've verified it.

I'm unable to see the impact of +direct damage gear on the ability mouseover.

dlebansais commented 2 years ago

Thanks for the report. I actually found two bugs related to Song of Discord.

When you say damage type is direct trauma damage (not indirect!) do you mean it's boosted by mods that only boost direct damage (all or just Trauma)?

In cases like that it is better if you can provide a file with the build you're talking about, and a screenshot of what it really does in the game. This way I can fix PGB to match.

Enphuego commented 2 years ago

The in game tool tip damage is wrong as well as the builder tool. The in game tooltip says 453.7 dmg per tick, actual is 506/572/639 on an unarmored training dummy. Build file provided.

The in game tool tip matches actual damage until I put on my Amazing Ring with "All Direct Damage +45" stat with "+21 Damage to Song of Discord" mod.

So to test - running just the minimum gear I can (Fairy Lute and Amazing Ring) it's 180 base damage + 13% Bard Base Damage + All Direct Damage +45 + Song of Discord +21 dmg. In game tool tip shows 224, actual damage is 269. The last screenshot is the minimum gear set I could use to demonstrate.

pg_bard_priest_dps_bug_test.txt Gorgon-2022-06-21-04-31-45Z Gorgon-2022-06-21-04-31-47Z Gorgon-2022-06-21-04-31-49Z

Gorgon-2022-06-21-04-41-41Z

dlebansais commented 2 years ago

Thank you for the report. These are valuable to me, though unfortunately not in this case. Just to clarify any misconception:

I went ahead to got myself a ring of directness (+7 direct damage, -5/tick indirect damage) with Song of Discord deals +12 damage, +stun mod on it.

If you find a configuration in game with mods where the formula (180 + (sum of +dmg)) * (sum of +% dmg) doesn't apply, please let me know!

Enphuego commented 2 years ago

The reduced power in the tooltip was the Bard rez mod (I used my healing lute). There's also a -power event buff right now so everything is showing green at the moment for power. I got a basic lute to help simplify testing.

If your goal is just to make the tool match the tooltip, then you can ignore the +dmg from the Amazing Magic Ring. It doesn't show in the tooltip but it does get applied (I will bug report it).

Sorry this is confusing because actual damage doesn't match tooltip damage (and I checked for buffs!)

Base - 180 tooltip 180 actual Amazing Magic Ring (+45) with +21 damage mod - 201 tooltip 246 actual (+45 difference)

Then this is where it gets weird. Fairy Lute, no ring (+13%) - 203.4 tooltip 203 actual Fairy Lute + ring Tooltip should show by your equation (180 + 21) 1.13 = 227.13
Actual tooltip shows 224.4 as if the +21 damage from the mod was added after the % damage modifier Damage by your equation should be (180 + 21 + 45)
1.13 = 277.98 Actual damage is 269

So your formula: (180 + (sum of +dmg)) * (sum of +% dmg) isn't correct

It should be (180 (sum of +% dmg)) + (sum of +dmg) Which means the actual should be (180 1.13) + (21 + 45) = 269.4 which matches actual damage

According to Yaffy, the full equation is as follows: ((Base damage + Flat damage) X% damage with attack + (Base damage Base multiplier - Base damage)) X% Damage type External multipliers X% Vulnerability debuff + External Flat damage X% More damage debuff

Source: https://forum.projectgorgon.com/showthread.php?1801-Damage-Calculation-Formula-amp-Why-Deadlier-Weapons-are-so-Strong&highlight=yaffy

dlebansais commented 2 years ago

I have updated the builder, but I'll leave this bug open until Song of Discord is fixed. Currently, I have to hack the formula for it and it's not working well anyway.