search

dlech / KeeAgent

ssh agent plugin for KeePass 2.x
http://lechnology.com/software/keeagent
Other
522 stars 35 forks source link

0.13.1 - Can not select attachment for new entry #351

Closed egfx-notifications closed 1 year ago

egfx-notifications commented 1 year ago

When adding a new entry to KeePass I can no longer activate a key attachment for KeeAgent 0.13.1 as the attachment selection dialog is missing, probably either behind the constraints table or further down below, but not accessible through a scrollbar

Using KeePass 2.47 (64-bit) on Windows 10

Screenshot 2022-07-28 160654

ChristianGfK commented 1 year ago

Works as expected here, with KeePass 2.52: image

I notice your UI looks very large, are you using UI scaling? You could try setting it to 100% and see if that helps at all, as a workaround.

egfx-notifications commented 1 year ago

I do. I just tried again without UI scaling and I also tried going down from 4K to HD resolution. Finally I tried using the current KeePass release instead of the older version my employer supplies. Unfortunately it still always looked like in my first screenshot.

egfx-notifications commented 1 year ago

Ok, looking at the code I am a bit confused why the DataGriedView has its Anchor set to Top, Bottom, Left, Right. I'd say Top, Left would be sufficient. Interestingly there is a commit (https://github.com/dlech/KeeAgent/commit/bef5a0d2d6094103075bba28c2c3c28370d6bc1c) setting the Anchor to Top, Left if Mono is used and the commit says it is to prevent the view from displaying over other controls, so that sounds exactly like the problem I have here. I assume that here on Windows 10 the .NET Framework would be used, but maybe the issue is identical to the one in Mono?

ChristianGfK commented 1 year ago

You could try forking, changing that, and using the GitHub actions (do they get forked as well?) to build a new .plgx. (I say that as if I had done it before, which I have not. :P)

egfx-notifications commented 1 year ago

You got a point there. Was reading up on what I have to get to build locally, but let's see if GitHub actions work.

egfx-notifications commented 1 year ago

Yes, I had to manually activate the GitHub Actions in my fork in order to confirm that I read and understood the workflows that would be run under my account, so did that and it worked. And the fix worked as well, so hoping for the PR to get merged :)

SugoiDev commented 1 year ago

I can confirm the issue happens on Windows 11 with kp 2.52 and no display scaling. I don't frequently add new keys, so I'm unsure when this started happening.

image

egfx-notifications commented 1 year ago

I can confirm the issue happens on Windows 11 with kp 2.52 and no display scaling. I don't frequently add new keys, so I'm unsure when this started happening.

image

Great, someone else with this issue :D

Can you test again with this version including my PR?

ziesemer commented 1 year ago

Can you test again with this version including my PR?

I can confirm that it fixed the UI issue for myself as well. I did test your updated version, but ran into other issues with KeeAgent - which I fully expect are unrelated to your fix, but going from 0.12.1 to 0.13.1 - or possibly, something in the build process itself. Specifically, I was no longer able to load existing PPK keys into the running agent. I'll try to narrow this down further yet sometime today and report back.

SugoiDev commented 1 year ago

Can you test again with this version including my PR?

Just tested and it looks good. Thanks for the PR!