search

dlecocq / nsq-py

Hacking on Python NSQ Bindings
MIT License
44 stars 16 forks source link

Reduce log severity of socket import messages #38

Closed mxr closed 8 years ago

mxr commented 8 years ago

SnappySocket and DeflateSocket aren't implemented yet. When we try to the import them, a warning is logged, but it isn't actionable.

Happy to add a test if need be.

dlecocq commented 8 years ago

LGTM, so long as the build passes

mxr commented 8 years ago

@dlecocq I think the build is broken on the master line - it times out after 10 minutes, after

The thread survives exceptions ... ok

I don't think this is related to my change. I got the same timeout in https://github.com/dlecocq/nsq-py/pull/39 (this was an experimental PR, to see if fixing nose.plugins.cover: ERROR: Coverage not available: unable to import coverage module would help)

Running make test locally fails fast however.

dlecocq commented 8 years ago

Ok. I'm working on making a vagrant image, and then I'll be turning my eyes to the Travis build.

dlecocq commented 8 years ago

I believe it was an issue with url-py, a new version of which was pushed not long ago. Go ahead and rebase off of master and it should be fixed and then we can get this merged!

mxr commented 8 years ago

OK. I'll submit a new PR since my branch is derived from lyft/nsq-py and I can't rebase that off master right now

mxr commented 8 years ago

Opened https://github.com/dlecocq/nsq-py/pull/42