search

dlehmhus / next-with-linaria

Linaria webpack loader for Next.js
MIT License
107 stars 7 forks source link

Undocumented global CSS handling #11

Closed thearnica closed 1 year ago

thearnica commented 1 year ago

Hey, thank you for the beautiful solution and unblocking my Next13 experiments.

So far I've noticed only one "big" problem (the other one is something about linaria vs webpack cache) related to global css and the expectations for css modules - aka "pure selectors"

Long story short - you have undocumented file pattern enabling non-pure selectors and the pattern is not really "sound" - I can imagine a file named css-reset.global.ts, but not css-reset.linaria.global.ts

Wondering if pattern can be changed a little bit and the solution documented.

dlehmhus commented 1 year ago

Hey @thearnica, I'm glad to hear that it helps your experiments. Unfotuantially I'm not quite sure if I got the issue, could you elaborate a bit more? I tried to document the rule here. Is there anything that could have been documented better?

thearnica commented 1 year ago

🙃 yep, everything is clearly documented. Now I am drinking the second cup of a coffee and thinking how did I miss that

Look like my issue was resolved 🤗, thank you