search

dleidert / openmediavault-upgrade

Script to upgrade openmediavault from one major release into the next
GNU General Public License v3.0
48 stars 1 forks source link

pre.d/10-remount-ro: Only attempt to unmount mounted shares #14

Closed godfuture closed 3 years ago

godfuture commented 3 years ago

I wanted to try out the upgrade script, but did not want to do it on my production system. I came up with the idea of doing a clonezilla backup and restore system disk in virtualbox. I had to adjust network to be able to access the guest, but it worked.

When executing the upgrade script I get:

Re-mounting /srv/dev-disk-by-label-download read-only
mount: /srv/dev-disk-by-label-download not mounted or bad option
In some cases useful info is found in syslog - try
dmesg | tail or so.

with journalctl -xe I see a lot of following errors for the missing mounts of missing discs: 'mountpoint_srv_dev-disk-by-label-download' status failed (1) -- /srv/dev-disk-by-label-download is not a mountpoint

Problem is now that my other mounts are not existant. I did not want to backup all my drives from production.

Could I hide those none existant mounts?

dleidert commented 3 years ago

You could remove or rename the script responsible for the remount for testing purposes:

mv pre.d/10-remount-ro mv pre.d/10-remount-ro.disabled
godfuture commented 3 years ago

Given the answer from dleidert, the upgrade process continued without the issue described here.

dleidert commented 3 years ago

Reopen with new header line.

dleidert commented 3 years ago

Test if the share is mounted before doing a remount-attempt. Maybe use /proc/mounts or findmnt.

dleidert commented 3 years ago

Is fixed in the 4 branch. Will be pushed to the other branches as well and tested there.