search

dlenski / gp-saml-gui

Interactively authenticate to GlobalProtect VPNs that require SAML
GNU General Public License v3.0
293 stars 66 forks source link

misleading openconnect_command print with -E #104

Open mythi opened 1 month ago

mythi commented 1 month ago

With the recently added -E arg, the following print is a bit misleading: https://github.com/dlenski/gp-saml-gui/blob/c46af04b3a6325b0ecc982840d7cfbd1629b6d43/gp_saml_gui.py#L435

dlenski commented 1 month ago

My thinking was that even if the user is requesting an alternative sudo-like command (with -E or -P), the user would still probably want to use sudo if replicating the command-line invocation directly.

However, well-thought and well-justified pull requests to change this would be welcome!

mythi commented 1 month ago

user would still probably want to use sudo if replicating the command-line invocation directly.

My use-case follows the openconnect non-root setup where I'm adding the following openconnect params: -s 'sudo -E /usr/share/vpnc-scripts/vpnc-script' -i vpn0 -b. With that, I can gp-saml-gui -E ....