search

dlenski / gp-saml-gui

Interactively authenticate to GlobalProtect VPNs that require SAML
GNU General Public License v3.0
293 stars 66 forks source link

Microsoft SAML contains XML in comment #79

Closed Ericson2314 closed 11 months ago

Ericson2314 commented 11 months ago

I get a page that says Login Successful! and inspecting the DOM (if I go to the URL manually) shows roughly:

<html>
  <head></head>
  <body>Login Successful!</body
  <!--
    <saml-auth-status>1</saml-auth-status>
    <prelogin-cookie>REDACTEDBAASE64==</prelogin-cookie>
    <saml-username>READACTEDUSERNAME/saml-username>
    <saml-slo>yes</saml-slo>
    <saml-SessionNotOnOrAfter></saml-SessionNotOnOrAfter>
  -->
</html>

gp-saml-gui doesn't seem to know how to parse this; the browser window is still open waiting for me to do more things, but there is no button to press.

dlenski commented 11 months ago

gp-saml-gui doesn't seem to know how to parse this;

Hmmm, thanks to #59, gp-saml-gui is supposed to know how to parse this.

Are you running an old version? If so, upgrade.

Are you running a version that includes #59? If so, run gp-saml-gui -vv (--verbose × 2!) and give us more details.

Ericson2314 commented 11 months ago

I'll double check the version, sorry about that.

Ericson2314 commented 11 months ago

Yup, the newer version works like a charm. Afterwords I do get an openconnect error, but that's not this project's fault. Thank you!

I will update the version packaged in Nixpkgs so others do not have this issue :). Does this project have version numbers or does one just grab the latest commit off master?

dlenski commented 11 months ago

Does this project have version numbers or does one just grab the latest commit off master?

No, no releases or tags yet.