dlenski / gp-saml-gui

Interactively authenticate to GlobalProtect VPNs that require SAML
GNU General Public License v3.0
293 stars 66 forks source link

Add a new --disable-proxy argument #94

Closed DragoonAethis closed 6 months ago

DragoonAethis commented 6 months ago

In our company, we have a mandatory HTTP(S) proxy to leave the internal network, but the proxy gateway is available only within that internal network - on most systems this is configured with HTTP/HTTPS/NO_PROXY environment variables. For some reason, WebViews ignore NO_PROXY vars and resolve the proxy address to access the VPN gateway, which fails since we're not on the VPN in the first place...

This PR allows disabling proxies in WebViews for systems configured to go through the proxy with a new --disable-proxy argument, but unable to access it from the outside of the VPN. Note that this affect the WebView only - requests/urllib3/etc will still use it if you don't have the correct NO_PROXY value to make them ignore the proxy for gateways.

DragoonAethis commented 6 months ago

Nevermind, this is the same as https://github.com/dlenski/gp-saml-gui/pull/87