Parse raw bits if possible

muued commented 1 year ago

Hi, thanks for your great project. Since the option to output the raw bits contained in the barcode has been added to the command line runner of zxing in v3.5.0, this can now be captured in this wrapper. Proposed changes:

Update the dependencies to the current version (v3.5.1) and jcommander to match the expected version
Add the option '--raw' to the invocation if the detected version is at least 3.5.0
Add a further field raw_bits to the BarCode class that stores the raw bits output (this might be a bit confusing given that there is an existing field name raw, but this is the least-breaking change)

Notes:

The parse method supports parsing the raw bits output, but is also fine if it's missing
As the existing logic to determine the zxing version doesn't work correctly, if the classpath is overridden via parameter / environment variable, this change will lead to call failures if a pre-3.5.0 version of zxing is passed via parameter / environment.

dlenski commented 10 months ago

Hi, sorry I overlooked this PR. I'm not sure how that happened! This looks great :+1:

It will directly solve #17 and #20, and may help solve #8 and #22.

As the existing logic to determine the zxing version doesn't work correctly,

Can you clarify this? As far as I can tell, the logic for determining the Java ZXing library version works fine in all ZXing versions I've tested with, including v3.5.1.

dlenski commented 10 months ago

Merged as cd4eb88.

muued commented 10 months ago

As the existing logic to determine the zxing version doesn't work correctly,

Can you clarify this? As far as I can tell, the logic for determining the Java ZXing library version works fine in all ZXing versions I've tested with, including v3.5.1.

The code only looks at the version of the jar that sits in the package installation directory. If you pass an alternate jar with a different version via classpath or environment variable (https://github.com/dlenski/python-zxing/blob/master/zxing/__init__.py#L46-L51) the version will be incorrectly determined, i.e. the version of the jar doing the work is not the one the python wrapper thinks (and reports on the command line).

dlenski / python-zxing

Parse raw bits if possible #26