search

dlesl / gb-io

A Rust library for parsing, writing and manipulating Genbank sequence files
MIT License
14 stars 5 forks source link

Nom=4.2.3 contains code that will be rejected by a future version of Rust #8

Open wsowens opened 9 months ago

wsowens commented 9 months ago

Hi there, thanks for your work on this project!

I got a compiler warning in a project that sues gb-io:

warning: the following packages contain code that will be rejected by a future version of Rust: nom v4.2.3
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1`

This is fixed in subsequent version of nom. It looks like #7 already addresses this issue, but the PR is still open. As someone currently using this package, I figured I would make this issue to say 1) I appreciate this package and 2) it would also appreciate if #7 could be merged at some point.

Also happy to lend a hand if there are still any difficulties porting from nom 4 to nom 7.

dlesl commented 9 months ago

Hi, it's been a while since I looked at it but I think that #7 is complete in that all the tests pass, looking at the code there is still a FIXME around error handling (stream_parser.rs, maybe other places too?) which would be good to get fixed before merging. If you have some time to take a look at that, and also generally just testing the branch with your project I would really appreciate it.

I appreciate this package

Thanks!

althonos commented 6 months ago

@dlesl : I can compile gb-io.py without any change using the nom-7 branch, and it passes the downstream Python tests as well.