dlespiau / patchwork

The freedesktop.org edition of patchwork. Patchwork is a web patch tracking system for projects using a mailing list for contributions and reviews.
http://patchwork-freedesktop.readthedocs.org/en/latest/
GNU General Public License v2.0
22 stars 13 forks source link

revision/X is missing on the POST URL example #116

Closed lsandov1 closed 8 years ago

lsandov1 commented 8 years ago

On the documentation: http://patchwork-freedesktop.readthedocs.org/en/latest/rest.html#post--api-1.0-series-(int- series_id)-revisions-(int- version)-test-results-

This is wrong:

POST /api/1.0/series/47/test-results/ HTTP/1.1
{
    "test_name": "checkpatch.pl",
    "state": "success",
    "url": "http://jenkins.example.com/logs/47/checkpatch.log",
    "summary": "total: 0 errors, 0 warnings, 10 lines checked"
}

It should be:

POST /api/1.0/series/47/revisions/2/test-results/ HTTP/1.1
{
    "test_name": "checkpatch.pl",
    "state": "success",
    "url": "http://jenkins.example.com/logs/47/checkpatch.log",
    "summary": "total: 0 errors, 0 warnings, 10 lines checked"
}

with the revisions/2 included on the URL

dlespiau commented 8 years ago

Do you want to send a patch for that? it could be a nice way to get your first contribution.

lsandov1 commented 8 years ago

sure, I can do that.