HamedGhodsi90 commented 5 years ago

Hi Dominik,

I have used your package. It is great But it has some problems. For example in the read_rpt section, for using a report file which has more sections, your package cannot recognize them. I have prepared a complete list which I suggest you replace them.

report_sections <- c("Element Count", "Pollutant Summary", "Landuse Summary", "Raingage Summary", "Subcatchment Summary", "LID Control Summary", "Node Summary", "Link Summary", "Cross Section Summary", "Analysis Options",

"Rainfall File Summary",

                 #"Rainfall Dependent I/I",
                 #"Control Actions Taken",
                 "Runoff Quantity Continuity", 
                 "Runoff Quality Continuity",
                 #"roundwater Continuity",
                 "Flow Routing Continuity",
                 "Quality Routing Continuity",
                 #"Highest Continuity Errors",
                 #"Time-Step Critical Elements",
                 "Highest Flow Instability Indexes", 
                 "Routing Time Step Summary", 
                 #"Subcatchment Results",
                 "Subcatchment Runoff Summary",
                 "Subcatchment Washoff Summary",
                 "LID Performance Summary",
                 "Groundwater Summary",
                 #"Node Results",
                 "Node Depth Summary", 
                 "Node Inflow Summary", 
                 "Node Surcharge Summary",
                 "Node Flooding Summary", 
                 "Storage Volume Summary",
                 "Outfall Loading Summary", 
                 #"Link Results",
                 "Link Flow Summary", 
                 "Flow Classification Summary",
                 "Conduit Surcharge Summary",
                 "Pumping Summary",
                 "Link Pollutant Load Summary")

dleutnant commented 5 years ago

Thank you @HamedGhodsi90. I am quite busy with other projects at the moment, so integrating your suggestion may take a while. However, If you would like to prepare a pull request I would be happy to review your code changes. What do you think?

dleutnant commented 5 years ago

to solve this issue, the following has to be done:

[x] extend vector with all possible report sections
[x] add a new function parse_section.SECTION_NAME for each added section

dleutnant commented 5 years ago

All sections are now integrated. See cca4c90fca30576597b1cd1ab207703710f795fb. One Issue #26 about rpt parsing remains.

HamedGhodsi90 commented 5 years ago

Hi, I hope all is well with you.

A new problem is detected when I am using the read_inp() function. The error is:

Error in loadNamespace(i, c(lib.loc, .libPaths()), versionCheck = vI[[i]]) : namespace ‘vctrs’ 0.1.0 is being loaded, but >= 0.2.0 is required

It was right until the last week. This error is something new, I am wondering if you could try this function and see if the same error would be appeared or not. If yes, it would be great if you could modify it and release a new version of that.

Thanks.

On Sat, Feb 23, 2019 at 6:25 AM Dominik Leutnant notifications@github.com wrote:

Closed #21 https://github.com/dleutnant/swmmr/issues/21.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dleutnant/swmmr/issues/21#event-2159544514, or mute the thread https://github.com/notifications/unsubscribe-auth/ApDWb2oKvpZN4NCp_V2FMlKdnyWm8fphks5vQSUVgaJpZM4YaeAG .

HamedGhodsi90 commented 5 years ago

The problem is solved. Thanks in advance. Sorry for the inconvenience.

Best wishes, Hamed

On Thu, Oct 3, 2019 at 2:20 PM Hamed Ghodsi hamed.ghodsi90@gmail.com wrote:

Hi, I hope all is well with you.

A new problem is detected when I am using the read_inp() function. The error is:

Error in loadNamespace(i, c(lib.loc, .libPaths()), versionCheck = vI[[i]]) : namespace ‘vctrs’ 0.1.0 is being loaded, but >= 0.2.0 is required

It was right until the last week. This error is something new, I am wondering if you could try this function and see if the same error would be appeared or not. If yes, it would be great if you could modify it and release a new version of that.

Thanks.

On Sat, Feb 23, 2019 at 6:25 AM Dominik Leutnant notifications@github.com wrote:

Closed #21 https://github.com/dleutnant/swmmr/issues/21.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dleutnant/swmmr/issues/21#event-2159544514, or mute the thread https://github.com/notifications/unsubscribe-auth/ApDWb2oKvpZN4NCp_V2FMlKdnyWm8fphks5vQSUVgaJpZM4YaeAG .

dleutnant / swmmr

read_rpt does not account for all report sections #21

"Rainfall File Summary",