search

dleutnant / swmmr

R Interface for US EPA's SWMM
https://cran.r-project.org/package=swmmr
39 stars 15 forks source link

Error opening large .out file #52

Closed jjsoper closed 1 year ago

jjsoper commented 4 years ago

Hello, I am receiving the following error when trying to open a very large (10GB) out file. 

> read_out(file = model. .... [TRUNCATED]
$error
[1] 3

I have traced this to the OpenSwmmOutFile function:

> swmmr:::OpenSwmmOutFile(outFile = model.file)
$error
[1] 3

Any ideas on what this error is referencing? I haven't had any issues so far when working with smaller sized files, so thinking that may be the issue.

Thanks, Josh

dleutnant commented 4 years ago

Indeed, .out files exceeding 2 GB are currently not supported (due to ftell https://stackoverflow.com/questions/16696297/ftell-at-a-position-past-2gb). @hsonne didn't you find a general solution to this?

hsonne commented 3 years ago

Hi @dleutnant, sorry for not responding, I was on vacation. Without any further check, it seems that I worked on the issue (https://github.com/hsonne/swmmr/pull/1) on the "mydev" branch of my fork of your repo: https://github.com/hsonne/swmmr/tree/mydev. You may try to install the package from there: 

install.packages("remotes")
remotes::install_github("hsonne/swmmr@mydev")
dleutnant commented 3 years ago

That's great! Are you interested in pushing your modifications to the origin so that others can benefit as well?

jjsoper commented 3 years ago

Can confirm that this works on my machine. Thanks!

hsonne commented 3 years ago

@jjsoper I am glad to hear that. @dleutnant Yes, I am interested. However, I cannot do it right now. I remember that I did many changes and I need some time to recap what I did. Unfortunately, I do not have the time right now.

dleutnant commented 3 years ago

No worries, take your time! :-)

dleutnant commented 3 years ago

@gaoxiangying This is rather a network (behind a proxy?) or access issue and most probably not related to {swmmr}. Please check if you can generally install a package from github.

gaoxiangying commented 3 years ago

@dleutnant Thanks!

hsonne commented 3 years ago

Hi @dleutnant! Long time no see! I have a question: Where is your dev branch? You already pulled some of my changes (#22, #23, #27, #28). I wanted to continue based on that branch.

dleutnant commented 3 years ago

Hi @hsonne! That's cool, looking forward to your contributions! Well, there isn't an official dev branch anymore. I use the main branch as the one with the latest developments, which eventually incorporates developments from other branches. (btw: I'm currently on paternity leave and very slow with responds ;) )

hsonne commented 1 year ago

The corresponding changes are now available on the dev branch of this repository. You can install the package from there with remotes::install_github("dleutnant/swmmr@dev").