dli-invest / fin_news_nlp

Financial nlp project to scan news sites for information built using spacy, fastapi, scrapy, cookercutter and various news sources.
Apache License 2.0
9 stars 4 forks source link

Feature/beneath scrapping wsb #10

Closed FriendlyUser closed 2 years ago

FriendlyUser commented 2 years ago

Closes #8 basic beneath integration

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 11.92%.

Quality metrics Before After Change
Complexity 5.11 ⭐ 7.92 ⭐ 2.81 👎
Method Length 49.36 ⭐ 65.18 🙂 15.82 👎
Working memory 7.38 🙂 9.59 🙂 2.21 👎
Quality 71.18% 🙂 59.26% 🙂 -11.92% 👎
Other metrics Before After Change
Lines 130 173 43
Changed files Quality Before Quality After Quality Change
nlp_articles/app/pull_beneath.py 83.07% ⭐ 43.81% 😞 -39.26% 👎
scrappers/parse_rss_cli.py 68.33% 🙂 68.33% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nlp_articles/app/pull_beneath.py main 12 🙂 258 ⛔ 14 😞 36.76% 😞 Try splitting into smaller methods. Extract out complex expressions
scrappers/parse_rss_cli.py iterate_cnbc_feed 8 ⭐ 127 😞 10 😞 57.67% 🙂 Try splitting into smaller methods. Extract out complex expressions
scrappers/parse_rss_cli.py main 9 🙂 138 😞 8 🙂 59.72% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!