dli-invest / fin_news_nlp

Financial nlp project to scan news sites for information built using spacy, fastapi, scrapy, cookercutter and various news sources.
Apache License 2.0
9 stars 4 forks source link

Feature/beneath scrapping wsb #13

Closed FriendlyUser closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #13 (38093fa) into main (d347d3c) will decrease coverage by 1.13%. The diff coverage is 18.18%.

:exclamation: Current head 38093fa differs from pull request most recent head 91634c5. Consider uploading reports for the commit 91634c5 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   72.03%   70.89%   -1.14%     
==========================================
  Files           8        8              
  Lines         261      268       +7     
==========================================
+ Hits          188      190       +2     
- Misses         73       78       +5     
Flag Coverage Δ
ga_ci 70.89% <18.18%> (-1.14%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nlp_articles/app/pull_beneath.py 0.00% <0.00%> (ø)
nlp_articles/app/nlp.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d347d3c...91634c5. Read the comment docs.

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.27%.

Quality metrics Before After Change
Complexity 14.46 🙂 15.65 🙂 1.19 👎
Method Length 88.15 🙂 94.54 🙂 6.39 👎
Working memory 11.78 😞 11.95 😞 0.17 👎
Quality 45.63% 😞 43.36% 😞 -2.27% 👎
Other metrics Before After Change
Lines 259 267 8
Changed files Quality Before Quality After Quality Change
nlp_articles/app/nlp.py 19.46% ⛔ 19.41% ⛔ -0.05% 👎
nlp_articles/app/pull_beneath.py 43.81% 😞 38.74% 😞 -5.07% 👎
scrappers/parse_rss_cli.py 68.33% 🙂 65.55% 🙂 -2.78% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nlp_articles/app/nlp.py init_nlp 27 😞 429 ⛔ 16 ⛔ 19.41% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nlp_articles/app/pull_beneath.py main 16 🙂 299 ⛔ 14 😞 31.75% 😞 Try splitting into smaller methods. Extract out complex expressions
scrappers/parse_rss_cli.py iterate_cnbc_feed 11 🙂 156 😞 11 😞 49.78% 😞 Try splitting into smaller methods. Extract out complex expressions
scrappers/parse_rss_cli.py main 9 🙂 138 😞 8 🙂 59.72% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!