ApDAR

[benhills]

This is a PR to integrate 'apdar' more thoroughly.

I need to write more unit tests before we merge it but it would be helpful if you can tell codecov to stop ignoring the Apres directory so that I can make sure there is good coverage.

[codecov[bot]]

Codecov Report

Base: 76.92% // Head: 78.46% // Increases project coverage by +1.54% :tada:

Coverage data is based on head (f831a00) compared to base (d6d601f). Patch coverage: 80.30% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## devel #29 +/- ## ========================================== + Coverage 76.92% 78.46% +1.54% ========================================== Files 50 61 +11 Lines 5262 6874 +1612 ========================================== + Hits 4048 5394 +1346 - Misses 1214 1480 +266 ``` | [Impacted Files](https://codecov.io/gh/dlilien/ImpDAR/pull/29?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien) | Coverage Δ | | |---|---|---| | [impdar/lib/ApresData/ApresHeader.py](https://codecov.io/gh/dlilien/ImpDAR/pull/29/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien#diff-aW1wZGFyL2xpYi9BcHJlc0RhdGEvQXByZXNIZWFkZXIucHk=) | `88.14% <50.00%> (ø)` | | | [impdar/lib/ApresData/\_ApresDataSaving.py](https://codecov.io/gh/dlilien/ImpDAR/pull/29/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien#diff-aW1wZGFyL2xpYi9BcHJlc0RhdGEvX0FwcmVzRGF0YVNhdmluZy5weQ==) | `65.43% <50.00%> (ø)` | | | [impdar/lib/load/load\_tek.py](https://codecov.io/gh/dlilien/ImpDAR/pull/29/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien#diff-aW1wZGFyL2xpYi9sb2FkL2xvYWRfdGVrLnB5) | `98.30% <50.00%> (ø)` | | | [impdar/lib/load/load\_pulse\_ekko.py](https://codecov.io/gh/dlilien/ImpDAR/pull/29/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien#diff-aW1wZGFyL2xpYi9sb2FkL2xvYWRfcHVsc2VfZWtrby5weQ==) | `72.43% <66.66%> (ø)` | | | [impdar/lib/ApresData/ApresFlags.py](https://codecov.io/gh/dlilien/ImpDAR/pull/29/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien#diff-aW1wZGFyL2xpYi9BcHJlc0RhdGEvQXByZXNGbGFncy5weQ==) | `66.00% <72.46%> (ø)` | | | [impdar/lib/ApresData/\_\_init\_\_.py](https://codecov.io/gh/dlilien/ImpDAR/pull/29/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien#diff-aW1wZGFyL2xpYi9BcHJlc0RhdGEvX19pbml0X18ucHk=) | `78.90% <73.86%> (ø)` | | | [impdar/lib/ApresData/load\_apres.py](https://codecov.io/gh/dlilien/ImpDAR/pull/29/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien#diff-aW1wZGFyL2xpYi9BcHJlc0RhdGEvbG9hZF9hcHJlcy5weQ==) | `73.95% <74.02%> (ø)` | | | [impdar/bin/apdar.py](https://codecov.io/gh/dlilien/ImpDAR/pull/29/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien#diff-aW1wZGFyL2Jpbi9hcGRhci5weQ==) | `76.63% <75.48%> (+76.63%)` | :arrow_up: | | [impdar/lib/load/load\_bsi.py](https://codecov.io/gh/dlilien/ImpDAR/pull/29/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien#diff-aW1wZGFyL2xpYi9sb2FkL2xvYWRfYnNpLnB5) | `77.21% <77.77%> (ø)` | | | [impdar/lib/ApresData/load\_time\_diff.py](https://codecov.io/gh/dlilien/ImpDAR/pull/29/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien#diff-aW1wZGFyL2xpYi9BcHJlc0RhdGEvbG9hZF90aW1lX2RpZmYucHk=) | `79.66% <79.66%> (ø)` | | | ... and [18 more](https://codecov.io/gh/dlilien/ImpDAR/pull/29/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Lilien)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[dlilien]

@benhills I am not sure how to modify the pull request since I cannot push to your fork--but you can get checks to run on codecov by deleting the ApRes folder glob from line 87 of .github/workflows/python-package.yml.

[benhills]

Thanks. I should have been able to figure that out on my own, but thanks for the pointer. I will update the testing scripts for more coverage.

[dlilien]

OK, just let me know when you are happy with test coverage and we can merge. It looks to me like the one failing check is some weird problem with the image, not with us, so I am fine ignoring that.

[benhills]

I still need to finish the docs but I think this PR is probably ready whenever. I can try to deal with that last pest in codecov as well.