search

dlilien / ImpDAR

An impulse radar processor
GNU General Public License v3.0
27 stars 19 forks source link

New BSI file structure #31

Closed benhills closed 2 years ago

benhills commented 2 years ago

Laurent built a new HF system for Knut which has two channels (one amped and one un-amped). He rewrote the file structure to accommodate both channels. There are also some variable name changes, see here: https://iprdoc.readthedocs.io/en/latest/File_format/#attributes-groups-summary

benhills commented 2 years ago

Sorry, I can deal with the merge conflicts on my end.

codecov[bot] commented 2 years ago

Codecov Report

Merging #31 (15ca98a) into devel (9fbfc5c) will increase coverage by 0.11%. The diff coverage is 76.66%.

@@            Coverage Diff             @@
##            devel      #31      +/-   ##
==========================================
+ Coverage   76.81%   76.92%   +0.11%     
==========================================
  Files          50       50              
  Lines        5224     5262      +38     
==========================================
+ Hits         4013     4048      +35     
- Misses       1211     1214       +3
Impacted Files Coverage Δ
impdar/lib/load/load_pulse_ekko.py 72.43% <66.66%> (-0.40%) :arrow_down:
impdar/lib/load/load_bsi.py 77.21% <77.77%> (+5.31%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

benhills commented 2 years ago

Hey @dlilien, not sure how strict you want to be about the codecov bot, but I am happy to bump up the testing enough to get the diff to clear. Outside of that, I think we are ready to merge this one. This is pretty much just a PR from the changes I made during the Waddington season. We were using the new BSI system and the Pulse Ekko, so I had to make minor changes to both load scripts.