Closed benhills closed 2 years ago
Merging #32 (d5a033e) into devel (d6d601f) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## devel #32 +/- ##
==========================================
+ Coverage 76.92% 76.95% +0.02%
==========================================
Files 50 50
Lines 5262 5272 +10
==========================================
+ Hits 4048 4057 +9
- Misses 1214 1215 +1
Impacted Files | Coverage Δ | |
---|---|---|
impdar/lib/RadarData/_RadarDataProcessing.py | 98.56% <100.00%> (-0.32%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
After looking at this closer I think we should make a bigger change to the nmo function. I can do it early next week but maybe don't merge this right away.
Knut was frustrated that the travel time vector went nonlinear from the moveout correction so I rewrote to interpolate onto equal spacing (with the original time step) between 0 and the deepest 'adjusted' time.
I am open to changing this function more too.
Also noticed some unnecessary complexities to how I originally wrote the variable velocity stuff so rewrote some of that.
I think this is ready. There is still an issue uploading to PyPi, but I can't tell if that is because we are still pointing to the deprecated "master" branch of if I don't have access to the API.
I think this was maybe a mistake? It could have been me who set this flag to true, can't remember. I am thinking it should be False by default but definitely let me know if you disagree.