Closed dlilien closed 1 year ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
3c1d992
) 78.24% compared to head (4f26a45
) 79.74%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Code is much cleaner, thanks. If you say it passes and the notebook migration looks good, then I am happy.
Yep, think it looks good:
Before:
After:
For FK migration, we had been using a complex fft on real data, then decimating (i.e. taking every other sample). I think this was a bug introduced by conversion from a Matlab script, although I am not positive. I see no reason, though, why this shouldn't be information-preserving.
I moved to using numpy's rfft, irfft, etc. There are additional changes to use RectBivariateSpline because of deprecation of interp2d. Tests pass and this looks good in the demo notebook.
@benhills, can you confirm that this acceptable before I merge it?