Closed EmmaErwin93 closed 1 year ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
adfca68
) 79.74% compared to head (27f5831
) 79.73%.:exclamation: Current head 27f5831 differs from pull request most recent head 9eaa658. Consider uploading reports for the commit 9eaa658 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@EmmaErwin93 I modified this so that it hopfully works simultaneously with old and new BSI data. I have confirmed that it works with old data again. Can you check that this version works with your new BSI data? I think you just need to git pull
your fork to get my changes.
@dlilien Just tried, but get an error:
Loading LabVIEW Boolean from raw/Eclipse-P2/eclipse-phase2.h5
Loading line_0 from raw/Eclipse-P2/eclipse-phase2.h5
Interpolating traces with bad GPS in line_0
Traceback (most recent call last):
File "/Users/emmaerwin/opt/miniconda3/bin/impdar", line 33, in
Ok, @EmmaErwin93 can you send me a file that is failing to load (or if you figured it out then just push the fix)? Sorry that this is complicated, but I know people are using ImpDAR with both old and new versions of BSI systems, so we need to provide some kind of solution that works for both.
This should be compatible with both versions now. @EmmaErwin93 let me know if there are any lingering problems.
@dlilien I think there is an error in line 163 of the load_bsi.py file: _xmlGetVal(digitizer_data, sample_rate_str) or 1.0)
should not have the "or 1.0" at the end -- I think i accidentally hard coded this for a test file I was doing, but it affects the time vector for any file that the sample_rate_str is not read in.
I think that sample_rate_str in line 103 needs to have a space in front: ' Sample Rate'
Updated for new variable names acquired with BSI update (Applied for UMAINE radar in spring 2023)