search

dlindahl / omniauth-cas

A CAS OmniAuth Strategy
MIT License
88 stars 79 forks source link

Upgrading nokogiri dependency to ~> 1.6 #11

Closed Pilooz closed 11 years ago

Pilooz commented 11 years ago

Hi Derek, I'm facing a dependency problem in my project, using omniauth-cas and others gems that require nokogiri verion 1.6. I have upgraded Gemspec : all specs have passed, with nokogiri 1.6.

Let me know what you think about that. best regards,

Pilooz

dlindahl commented 11 years ago

Merged, version bumped, and released.

Thanks!

dlindahl commented 10 years ago

@Pilooz Just out of curiosity, what dependency problems did you experience? The original version dependency should have work fine for you since it would have allowed anything over v1.6.

I'm asking because this patch has apparently caused dependency problems for others (See #19)

/cc @sag47

samrocketman commented 10 years ago

@dlindahl https://github.com/gitlabhq/gitlabhq/blob/6-1-stable/Gemfile.lock there are multiple dependencies of nokogiri ~> 1.5 which is why I encountered the issue setting up gitlab. I modified the omniauth-cas Gemfile to be nokogiri >= 1.5 which resolved it. Otherwise I could not use it. In newer versions of Gitlab, this may change but that's where I encountered the issue.

Pilooz commented 10 years ago

Hi @dlindahl, As far as I remember, I had a problem with nokogiri dependency with the gem fog in the version 1.12 and before. Perhaps the spermy dependency (~>1.6) was to strong. I have to update my bundle and see.

dlindahl commented 10 years ago

@Pilooz The previous code used ~> 1.5, which would have allowed >= 1.5 and < 2.0, so I'm surprised you had a problem.

Unless you can find an issue with omniauth-cas itself, I am going to revert this PR and lower the dependency back to 1.5