search

dlindahl / omniauth-cas

A CAS OmniAuth Strategy
MIT License
88 stars 79 forks source link

Feature/configurable values returned by cas #20

Closed samrocketman closed 10 years ago

samrocketman commented 10 years ago

Fixes Issue #15.

More options for values handed back by CAS. This is needed because different auth strategies for CAS sometimes hand back different keys for these items. They're not configurable on an application basis. Only globally. This means omniauth-cas needs to be more flexible and setting defaults while you're at it.

Thanks for maintaining omniauth-cas :cake:

samrocketman commented 10 years ago

I'll work on fixing the build ~.~

samrocketman commented 10 years ago

@dlindahl I have a question for you. Currently my added code is not being tested in the tests. Should I modify the fixtures xml files and this initializing test or should I add a whole new XML file to the fixtures directory and re-initialize the phony environment?

samrocketman commented 10 years ago

@dlindahl I take that back it looks like the tests do cover the configurable variables because it is taking the default values from them.

dlindahl commented 10 years ago

I had to do some minor tweaks to a couple of the commits (including some adjustments when rebasing with master)

This has been merged in with 2e951d2..dcc949e