search

dlindahl / omniauth-cas

A CAS OmniAuth Strategy
MIT License
88 stars 79 forks source link

Docs/undocumented callback url #21

Closed samrocketman closed 9 years ago

samrocketman commented 10 years ago

This documents the undocumented callback url on top of Pull Request #20. This is current a feature that already exists in master which is why I made a separate pull request to differentiate it.

dlindahl commented 10 years ago

It looks like this includes your patches for #20 as well. Is this intentional? If not, is it possible to rebase this PR to only include the changes necessary to implement the change?

samrocketman commented 10 years ago

It does, because I based it off of the branch. Do you plan on including #20? If so then we can close this and I'll wait for the master to be updated and redo this pull request after master.

The reason why I did it this way is because if I did this pull request off of master and #20 off of master then there would be a merge conflict with the PRs.

dlindahl commented 10 years ago

@sag47 - I do intend to take a serious look at this and the other issues once I get SSO support stable. I am balancing a late project in my real world job, building a CAS server in my spare time, and planning a move across the US. So please be patient :smile:

I'm OK leaving this open as it is until I merge #20 in.

samrocketman commented 10 years ago

@dlindahl No worries. Thanks for letting me know.

dlindahl commented 10 years ago

Ok, #20 has been merged in. So if you could either rebase this PR with master or create a new PR, that'd be great.

samrocketman commented 10 years ago

Sure, I'll try to get to it tomorrow with a PR.