remove initilize and move :url attribute processing into cas.rb

dlindahl / omniauth-cas

A CAS OmniAuth Strategy

MIT License

88 stars 79 forks source link

remove initilize and move :url attribute processing into cas.rb #26

Closed eriko closed 10 years ago

eriko commented 10 years ago

Ok this does the same as my last attempt without removing the :url attribute. The two differences are url option is only extracted if present and validate_cas_setup is run each time. As with the existing code the cas_url is constructed each time. Now apps that use this can test server configurations without restarting the app.

dlindahl commented 10 years ago

Merged and closed with 37d5c49

dlindahl commented 10 years ago

PS: Protips for your next open source contrib:

Respect the project's whitespace settings (tabs vs spaces)
If the project has tests, write some to support your work
If the project has tests, ensure they pass with your change

Thanks for the contribution! :beers:

eriko commented 10 years ago

Your comment is correct. Sorry about that.