search

dlindahl / omniauth-cas

A CAS OmniAuth Strategy
MIT License
88 stars 79 forks source link

Add `nickname` to info hash. #29

Closed cmhamill closed 9 years ago

cmhamill commented 10 years ago

Also, expose a nickname_key setting, defaulting to 'user'.

I'm adding this because:

  1. It's in the spec.
  2. At some point GitLab starting using it to populate its username.

I don't know for sure that this is the best way to handle that, as I feel as though GitLab is kind of Doing it Wrong™, but that's your call.

Incidentally, do you have any plans to make another release and push it to rubygems at any point? I'd like to use this in production but I like releases...