search

dlindahl / omniauth-cas

A CAS OmniAuth Strategy
MIT License
88 stars 79 forks source link

Forward success response to fetch_raw_info callback (#47) #51

Closed danschmidt5189 closed 5 years ago

danschmidt5189 commented 6 years ago

Exposes ServiceTicketValidator.success_body and passes it as a fifth argument to the user-supplied fetch_raw_info callback. This gives new clients access to the raw CAS XML response, allowing them to solve issues like #47 without breaking parsing for existing clients.

There were previously no tests for the fetch_raw_info callback. That is now implicitly tested by checks on new cas:roles fixture elements, which are populated by that callback.

vjt commented 6 years ago

Thanks for this. I have no objection to merge, I'll wait to hear from other collaborators.

Thanks!

danschmidt5189 commented 6 years ago

@vjt We tried this out on a few internal apps and were reminded that it's a breaking change for developers using lambda, which has an arity check. Developers using Proc are unaffected. I updated the README accordingly.

That might also be worth noting in the Changelog, but I'll leave that to you and the other maintainers.

Thank you!