search

dlindahl / omniauth-cas

A CAS OmniAuth Strategy
MIT License
88 stars 79 forks source link

Travis: Test w/Ruby 2.4 and 2.5 #56

Closed danschmidt5189 closed 5 years ago

danschmidt5189 commented 5 years ago

Waiting to see how much of a build time penalty this incurs. If it's small, I don't see a good reason not to check these versions.

danschmidt5189 commented 5 years ago

Lit up with red—https://travis-ci.org/dlindahl/omniauth-cas/jobs/493514439

Looks related to mocking, which explains why the problem hasn't blown up our environments at Cal. I'll take a look…

danschmidt5189 commented 5 years ago

This bumped the build time to ~7m30s (from ~6m30s in the previous successful run). I think that's a minor hit to get the extra coverage. (E.g. the team I work with at Cal is almost exclusively on 2.5.) I doubt we'll be making too many changes, but on the off chance we anger the Ruby version gods I'd rather have the check.