search

dlindahl / omniauth-cas

A CAS OmniAuth Strategy
MIT License
88 stars 79 forks source link

Add support for multivalued attributes #59

Closed jking916 closed 3 years ago

jking916 commented 3 years ago

Currently we use CAS to return multi-valued attributes like entitlements/roles, which aren't natively supported by this omniauth provider and instead get set to the last value returned. Looking to add optional support for returning these multi-valued attributes as arrays while maintaining backwards compatibility by default.

vjt commented 3 years ago

@tagliala could you help in updating omniauth-cas in one of our projects to this branch to ensure nothing is broken?

Thank you

vjt commented 3 years ago

This worked well in our environment (thanks @tagliala!) and it is backwards compatible, thus merging.

Thanks!

jking916 commented 3 years ago

Thanks to you both! I noticed that there hasn't been a new release in a while (also brought up in #53). Is this waiting on an owner or a change in ownership?

vjt commented 3 years ago

Derek @dlindahl has already granted gem ownership to me and other contributors, so we can definitely cut a new release once this is merged

jgribonvald commented 3 years ago

Please could you publish a new release quickly ?

Thanks a lot for this update !

vjt commented 3 years ago

Sure, I’ll cut release 2.0.0 today. Thanks for thr heads up.

Marcello -- // vjt@openssl.it // https://sindro.me/

On 14 Nov 2020, at 12:48, Julien Gribonvald notifications@github.com wrote:

 Please could you publish a new release quickly ?

Thanks a lot for this update !

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

vjt commented 3 years ago

@jgribonvald 2.0.0 has been pushed to Ruby Gems.

Enjoy and please revert back if something is wrong.

Cheers!

jgribonvald commented 3 years ago

@vjt thanks a lot, I will let you know if something goes wrong.