Previously, we were looking for request.params['url'], and assuming that if it was present, it would be in the original query string and OmniAuth would already have appended it to the callback URL.
With this change, the behavior for a url parameter in the query string (Rack::Request#GET) is unchanged. However, if there is no url parameter in the query string, but there is one in the form body (Rack::Request#POST), we transfer the value from the form body to the callback URL query string.
As a fallback, we use the HTTP Referer value, just as OmniAuth does for the origin parameter. However, we were previously appending it unconditionally, whether or not it was actually present (as it often isn’t, for various reasons), resulting in an empty url query parameter in the callback URL. With this change, we now only append the referrer if non-nil.
Previously, we were looking for
request.params['url'], and assuming that if it was present, it would be in the original query string and OmniAuth would already have appended it to the callback URL.With this change, the behavior for a
urlparameter in the query string (Rack::Request#GET) is unchanged. However, if there is nourlparameter in the query string, but there is one in the form body (Rack::Request#POST), we transfer the value from the form body to the callback URL query string.As a fallback, we use the HTTP
Referervalue, just as OmniAuth does for theoriginparameter. However, we were previously appending it unconditionally, whether or not it was actually present (as it often isn’t, for various reasons), resulting in an emptyurlquery parameter in the callback URL. With this change, we now only append the referrer if non-nil.Fixes #66.