search

dlindahl / omniauth-cas

A CAS OmniAuth Strategy
MIT License
88 stars 79 forks source link

Update for OmniAuth v2 #68

Closed stanhu closed 10 months ago

stanhu commented 2 years ago

OmniAuth v2 converts all GET requests to POST requests by default with CSRF protection.

Closes https://github.com/dlindahl/omniauth-cas/issues/62

jcmfernandes commented 2 years ago

Hey @dlindahl mind reviewing and merging this, and then releasing it with a major version bump? mastodon uses this gem and it's stuck on OmniAuth v1 because of it. Thank you so much! :raised_hands:

armandfardeau commented 1 year ago

Hi, wanted to know where you are on this. We use your gem (thank you by the way) in some of our projects and need to update soon.

ZephOne commented 1 year ago

Hi, do you have any news about merging this pull request ? Do not hesitate if you need help.

tagliala commented 1 year ago

Hi, as the opener of #62, I was working on this feature

I have no permissions to merge PRs here, but I have indeed a branch (based on an outdated version of this gem, sorry)

I think that this two commits should be part of this feature, since they will keep testing against OmniAuth 1: https://github.com/dlindahl/omniauth-cas/commit/23b124d1c96c560cec5679b14e5195bdf898695d https://github.com/dlindahl/omniauth-cas/commit/1744cbb37d3fefa93f3966771605b004328189a1

vjt commented 1 year ago

I can merge PRs here as @dlindahl had once granted me access - @dlindahl as @tagliala is still actively working on this gem, may you grant rights to him as well?

In the meantime I can merge this if instructed to do so (sorry I am too much out of context at this point :-)

Thank you!

mjankowski commented 1 year ago

Would love to see this merged -- we're currently pointing at the PR branch in a larger omniauth update PR, and would prefer to point at an official release of omniauth-cas, or at least a non-PR branch if possible. Thanks everyone for the work here!

FedeJure commented 10 months ago

Hi, Why this is not merged yet??? I would like to see this mr merged too.

tagliala commented 10 months ago

Superseded by #82, thanks!

tagliala commented 9 months ago

Hello, is someone using the v3 beta? Can we release v3?